search

voila-dashboards / tljh-voila-gallery

Configuration for deploying the Voilà Gallery with The Littlest JupyterHub
BSD 3-Clause "New" or "Revised" License
82 stars 70 forks source link

Update the Docker installation #87

Open jtpio opened 4 years ago

jtpio commented 4 years ago

We currently install docker using the tljh_extra_apt_packages hook:

https://github.com/voila-dashboards/tljh-voila-gallery/blob/f7bac2d76e17f4596fcfec60d1d0bb7d91c2f2b6/tljh-voila-gallery/tljh_voila_gallery/__init__.py#L75-L79

However the Docker documentation recommends uninstalling docker.io and use a different procedure instead:

https://docs.docker.com/engine/install/ubuntu/

We could then add the steps to install docker-ce in the tljh_post_install hook instead:

https://github.com/voila-dashboards/tljh-voila-gallery/blob/f7bac2d76e17f4596fcfec60d1d0bb7d91c2f2b6/tljh-voila-gallery/tljh_voila_gallery/__init__.py#L82-L84

By executing apt commands directly, similar to what is done in TLJH:

https://github.com/jupyterhub/the-littlest-jupyterhub/blob/bdaab082ea1171b65a30bd93e27db4fc9b694a44/bootstrap/bootstrap.py#L127-L129