voila-dashboards / voici

Voici turns any Jupyter Notebook into a static web application
https://voici.readthedocs.io/
Other
143 stars 8 forks source link

Missing scripts to build the documentation? #112

Closed jtpio closed 2 months ago

jtpio commented 4 months ago

Description

Looks like the scripts to build the documentation (added in https://github.com/voila-dashboards/voici/pull/60) are now missing from the top-level pyproject.toml?

https://github.com/voila-dashboards/voici/blob/8d310fe41105114dac94dd1007e664c7acb32327/pyproject.toml#L1-L24

While they are still mentioned in the contributing guide:

https://github.com/voila-dashboards/voici/blob/main/CONTRIBUTING.md#documentation

image

Reproduce

https://github.com/voila-dashboards/voici/blob/8d310fe41105114dac94dd1007e664c7acb32327/pyproject.toml#L1-L24

Expected behavior

It should be possible to build the docs locally easily.

Context

Re-add scripts from #60?

jtpio commented 4 months ago

@martinRenou looks like they were removed in https://github.com/voila-dashboards/voici/pull/106 ?

martinRenou commented 2 months ago

Probably yes. Might have been an oversight