search

voila-dashboards / voici

Voici turns any Jupyter Notebook into a static web application
https://voici.readthedocs.io/
Other
145 stars 8 forks source link

Check correctness of the bump version script #46

Closed jtpio closed 1 year ago

jtpio commented 1 year ago

Description

It appears that the version of the @voila-dashboards/voila package is currently set to 0.4.0-alpha.0:

https://github.com/voila-dashboards/voici/blob/d73c5c33e1a46b2ab507aaa00b67e22e93193c9a/packages/voici/package.json#L3

While it's 0.3.0 for the Python version:

https://github.com/voila-dashboards/voici/blob/d73c5c33e1a46b2ab507aaa00b67e22e93193c9a/voici/_version.py#L18

Expected behavior

We should probably align the versions. It would be fine to be on 0.3.0 for Python and 0.4.0 for the JS packages.

jtpio commented 1 year ago

Gonna have a look. We might want to simplify the version spec to allow passing:

jtpio commented 1 year ago

It would be fine to be on 0.3.0 for Python and 0.4.0 for the JS packages.

Or let's re-align now while it's still early, as there doesn't seem to be any 0.3.0 published on npm:

image