search

voila-dashboards / voici

Voici turns any Jupyter Notebook into a static web application
https://voici.readthedocs.io/
Other
156 stars 9 forks source link

Create CONTRIBUTING.md #52

Closed jtpio closed 1 year ago

jtpio commented 1 year ago

References

Fixes #48

Code changes

Add documentation for contributing to the Voici.

User-facing changes

None

Backwards-incompatible changes

None

jtpio commented 1 year ago

So the UI tests seem to be failing (also noticed in #50):

image

Looks like it could be something related to the latest ipywidgets releases.

cc @martinRenou who might know more about it.

martinRenou commented 1 year ago

cc @martinRenou who might know more about it.

I'm not aware of any recent CSS change in ipywidgets that would cause this

jtpio commented 1 year ago

Not necessarily CSS but the widget rendering the error:

image

I'll try to reproduce locally.

martinRenou commented 1 year ago

Sorry I missed the widget error view in your screenshot. I thought this was only some padding.

We may want to print the console.log to the terminal so that we see the error message.

jtpio commented 1 year ago

Hmm it seems to be fine locally:

image

Although not sure CI is doing anything special for the UI tests.

jtpio commented 1 year ago

I opened https://github.com/voila-dashboards/voici/issues/53 as a follow-up since this does not seem related to this PR or #50.