search

voila-dashboards / voici

Voici turns any Jupyter Notebook into a static web application
https://voici.readthedocs.io/
Other
143 stars 8 forks source link

Fix: Proper redirect URL when we have just one Notebook #76

Open martinRenou opened 1 year ago

martinRenou commented 1 year ago

References

I've encountered this in https://github.com/martinRenou/voici-jupytercon-2023 where our content is a directory with just one Notebook with a data file. Then the redirect URL would not automatically be the Notebook.

Code changes

Actually count the Notebooks in the contents

github-actions[bot] commented 1 year ago

lite-badge :point_left: Try it on ReadTheDocs

trungleduc commented 1 year ago

Do we want this behavior? Because it's not the same as in voila.

trungleduc commented 1 year ago

Thinking of it, there is no way to start a single dashboard with external files without using the directory as contents, should we split the path to notebooks and the path to the resources dir in the CLI?

martinRenou commented 1 year ago

Thinking of it, there is no way to start a single dashboard with external files without using the directory as contents

Exactly, that was the original intent of the PR. I haven't thought of the impact on the CLI api that diverges from Voila.

should we split the path to notebooks and the path to the resources dir in the CLI?

I don't know.

Maybe this needs further discussion and we should not rush into implementing something before JupyterCon. I turn this into draft and we can discuss further.