search

voila-dashboards / voici

Voici turns any Jupyter Notebook into a static web application
https://voici.readthedocs.io/
Other
143 stars 8 forks source link

voici demo loader seems to load forever without any visible error message on Firefox #80

Closed ogrisel closed 11 months ago

ogrisel commented 1 year ago

Steps to reproduce

image

When opening the dev console, I see suspicious things like:

ERROR: received bad message: No such comm registered: 08442fbb-9452-43d7-b95a-5ed55d7bb8c0 [xpython_wasm.js:9:52250](https://voici.readthedocs.io/en/latest/_static/lite/extensions/@jupyterlite/xeus-python-kernel/static/xpython_wasm.js)

Uncaught (in promise) TypeError: i is null
    _onMessage https://voici.readthedocs.io/en/latest/_static/lite/voici/build/9757.js:1
    enable https://voici.readthedocs.io/en/latest/_static/lite/voici/build/9757.js:1
    activate https://voici.readthedocs.io/en/latest/_static/lite/voici/build/4530.js:2
    promise callback*activate https://voici.readthedocs.io/en/latest/_static/lite/voici/build/4530.js:2
    promise https://voici.readthedocs.io/en/latest/_static/lite/voici/build/6219.js:2
    promise callback*76219/t.prototype.activatePlugin/d</< https://voici.readthedocs.io/en/latest/_static/lite/voici/build/6219.js:2
    u https://voici.readthedocs.io/en/latest/_static/lite/voici/build/6219.js:2
    u https://voici.readthedocs.io/en/latest/_static/lite/voici/build/6219.js:2
    u https://voici.readthedocs.io/en/latest/_static/lite/voici/build/6219.js:2
    u https://voici.readthedocs.io/en/latest/_static/lite/voici/build/6219.js:2
    activatePlugin https://voici.readthedocs.io/en/latest/_static/lite/voici/build/6219.js:2
    r https://voici.readthedocs.io/en/latest/_static/lite/voici/build/6219.js:2
    start https://voici.readthedocs.io/en/latest/_static/lite/voici/build/6219.js:2
    47002 https://voici.readthedocs.io/en/latest/_static/lite/voici/build/7002.js:1
    47002 https://voici.readthedocs.io/en/latest/_static/lite/voici/build/7002.js:1
    c https://voici.readthedocs.io/en/latest/_static/lite/voici/build/voici.js:1
    promise callback*37559 https://voici.readthedocs.io/en/latest/_static/lite/voici/build/voici.js:1
    c https://voici.readthedocs.io/en/latest/_static/lite/voici/build/voici.js:1
    <anonymous> https://voici.readthedocs.io/en/latest/_static/lite/voici/build/voici.js:1
    <anonymous> https://voici.readthedocs.io/en/latest/_static/lite/voici/build/voici.js:1
6 9757.js:1:15399

Beyond fixing the demo to run with Firefox, it would be great for the loader would display an explicit message in case of loading error such as ("Error loading the voici demo, open the developer console and reload for details.") with an option to include a link to a project specific issue tracker to make it easy for users to report the problem to the maintainers of the demo app.

martinRenou commented 1 year ago

Thanks for opening an issue. This is probably due to the service worker that serves files in jupyterlite (that we use in Voici whenever you want to read a file).

We'll need to make a pass on making the service worker more robust there.

martinRenou commented 11 months ago

Not seeing any issue with Firefox anymore.