voila-dashboards / voila-heroku

Voilà application deployed on Heroku
Other
66 stars 65 forks source link

version of libraries in requeriments. #4

Open joseberlines opened 4 years ago

joseberlines commented 4 years ago

in point 4: Add the dependencies needed for running your Notebook in the requirements.txt file

In the requirements file there is no mention of versions of libraries. Is that not important? with a simple name (numpy, pandas, etc) heroku would normally get the last version. Is that right?

thanks

martinRenou commented 4 years ago

Thanks for opening an issue.

Indeed it does get the latest version. I am generally in favor of getting the latest version, but you might want to pin the exact version you need for some libraries if your Notebook is not compatible with the latest.

Maybe pointing to some documentation for the requirements.txt file would be a nice addition.