search

voila-dashboards / voila-vuetify

Dashboard template for Voilà based on VuetifyJS
Other
154 stars 41 forks source link

Put notebook name instead of Voila vuetify #25

Open yarmenti opened 4 years ago

yarmenti commented 4 years ago

Hi,

I wanted to modify the voila.tpl specifying the notebook name instead of "Voila vuetify". However, when I'm looking at the resources that are passed to the template, the only location I could put it is the notebook metadata.

However, in resources.metadata, the only key/value pair set is: "name"/"Notebook".

I tried, using the UI editor to change the "name" attribute of my notebook metadata but it doesn't work. Do you have any idea on how to do so?

Thank you,

maartenbreddels commented 4 years ago

The original template does this: https://github.com/voila-dashboards/voila/blob/8076df20102325827cca62f658c51bf9b5c99916/share/jupyter/voila/templates/default/nbconvert_templates/base.tpl#L9

Do you think the voila-vuetify template should also have this?

yarmenti commented 4 years ago

Well, from my point of view, hard-coding the template (app.html) or the resources when opening voila with the current template is not relevant when dealing with the notebook name. Thus, why not?