search

voila-dashboards / voila-vuetify

Dashboard template for Voilà based on VuetifyJS
Other
154 stars 41 forks source link

MDI dependency #53

Closed guimillet closed 3 years ago

guimillet commented 3 years ago

The base template downloads a Material Design Icons CSS with a version 4.4.95 but ipyvuetify seems to rely on more recent versions, which ends up in some icons missing when rendering with voila-vuetify templates.

Ipyvuetify has two (is it an error?) dependencies related to mdi in js/package.json:

    "@mdi/font": "^4.9.95",
    "material-design-icons-iconfont": "^5.0.1",

It seems appropriate to maintain a same version of MDI between ipyvuetify and voila-vuetify.

mariobuikhuizen commented 3 years ago

"material-design-icons-iconfont": "^5.0.1" was used in an older version of Vuetify, we kept it around after using @mdi/font": "^4.9.95 when upgrading to Vuetify 2.0 for backward compatibility.

To my knowledge, ipyvuetify (which is based on Vuetify 2.3.1) uses @mdi/font 4.9.95.

guimillet commented 3 years ago

Thanks Mario, so share/jupyter/nbconvert/templates/vuetify-base/index.html.j2#L9 should be updated to <link href='https://cdn.materialdesignicons.com/4.9.95/css/materialdesignicons.min.css' rel="stylesheet">.

mariobuikhuizen commented 3 years ago

Ah, I overlooked the change in the middle version number from 4 to 9, thanks for pointing this out.