voila-dashboards / voila

Voilà turns Jupyter notebooks into standalone web applications
https://voila.readthedocs.io
Other
5.42k stars 503 forks source link

Update the tree view so that URLs are correct for Voici #1299

Closed martinRenou closed 1 year ago

martinRenou commented 1 year ago

This allows Voici to have URLs like /voici/render/my-notebook.html

github-actions[bot] commented 1 year ago

Binder :point_left: Launch a Binder on branch _martinRenou/voila/frontendurl

trungleduc commented 1 year ago

Hey @martinRenou, since you are opening voila in your IDE, can you pin yarn to 1.x to make the test work?

github-actions[bot] commented 1 year ago

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser. For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table | Test file | voila-tree-classic.ipynb | voila-tree-light.ipynb | voila-tree-dark.ipynb | voila-tree-miami.ipynb | basics.ipynb | bqplot.ipynb | dashboard.ipynb | gridspecLayout.ipynb | interactive.ipynb | ipympl.ipynb | multiple_widgets.ipynb | query-strings.ipynb | reveal.ipynb | | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | | **Render** | | | | | | | | | | | | | | | `chromium` | | | | | | | | | | | | | | | actual | 90 <- [91 - 106 - 132] -> 199 | 68 <- [71 - 79 - 94] -> 139 | 65 <- [69 - 76 - 87] -> 121 | 64 <- [69 - 77 - 92] -> 121 | 2517 <- [2666 - 2729 - 2834] -> 3824 | 2316 <- [2346 - 2420 - 2561] -> 2603 | 2582 <- [2589 - 2602 - 2774] -> 2934 | 2338 <- [2346 - 2421 - 2532] -> 2652 | 1928 <- [2002 - 2069 - 2148] -> 2343 | 3162 <- [3185 - 3302 - 3428] -> 3871 | 3826 <- [3888 - 3951 - 4160] -> 4331 | 1565 <- [1575 - 1593 - 1620] -> 1678 | 2669 <- [2696 - 2732 - 2874] -> 3036 | | expected | 3379 <- [3442 - 3517 - 3701] -> 3876 | 2976 <- [3227 - 3321 - 3421] -> 3604 | 3608 <- [3623 - 3709 - 3793] -> 3825 | 4453 <- [4453 - 4523 - 4661] -> 4748 | 2559 <- [2655 - 2656 - 2660] -> 2674 | 3982 <- [4079 - 4213 - 4356] -> 4743 | 12183 <- [18509 - 19553 - 20811] -> 21515 | 15319 <- [15660 - 15796 - 15912] -> 16056 | 1517 <- [1920 - 1997 - 2103] -> 2113 |

:exclamation: Test metadata have changed ```diff --- /dev/fd/63 2023-03-03 16:54:24.585585737 +0000 +++ /dev/fd/62 2023-03-03 16:54:24.585585737 +0000 @@ -4,49 +4,49 @@ "BENCHMARK_REFERENCE": "actual" }, "browsers": { - "chromium": "97.0.4666.0" + "chromium": "94.0.4595.0" }, "systemInformation": { "cpu": { - "brand": "Xeon® Platinum 8370C", + "brand": "Xeon® E5-2673 v3", "cache": { - "l1d": 98304, + "l1d": 65536, "l1i": 65536, - "l2": 2097152, - "l3": 50331648 + "l2": 524288, + "l3": 31457280 }, "cores": 2, "family": "6", - "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear", + "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear", "governor": "", "manufacturer": "Intel®", - "model": "106", + "model": "63", "physicalCores": 2, "processors": 1, "revision": "", "socket": "", - "speed": 2.8, + "speed": 2.4, "speedMax": null, "speedMin": null, - "stepping": "6", + "stepping": "2", "vendor": "GenuineIntel", "virtualization": false, "voltage": "" }, "mem": { - "total": 7281278976 + "total": 7291699200 }, "osInfo": { "arch": "x64", "build": "", - "codename": "Jammy Jellyfish", + "codename": "Focal Fossa", "codepage": "UTF-8", "distro": "Ubuntu", - "kernel": "5.15.0-1033-azure", + "kernel": "5.8.0-1040-azure", "logofile": "ubuntu", "platform": "linux", - "release": "22.04.2 LTS", - "serial": "b19978ad27ef4e12840827283b4b81b5", + "release": "20.04.3 LTS", + "serial": "cfc067bfcb844f35865e279a1b0e66c5", "servicepack": "", "uefi": false } ```
martinRenou commented 1 year ago

https://github.com/voila-dashboards/voila/pull/1300

trungleduc commented 1 year ago

Thanks @martinRenou