Closed trungleduc closed 1 year ago
update galata references
pre-commit.ci run
update galata references
The execution time (in milliseconds) are grouped by test file, test type and browser. For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.
Not sure it's related but the Binder seems to be failing to build:
Wanted to double check the switch to Jupyter Server 2 does not cause issues on Binder.
Not sure it's related but the Binder seems to be failing to build:
Wanted to double check the switch to Jupyter Server 2 does not cause issues on Binder.
It works now
🚀 !
@trungleduc do you think it would be feasible to backport this to Voila 0.4? Or should this be considered a breaking change?
@meeseeksdev please backport to 0.4.x
Owee, I'm MrMeeseeks, Look at me.
There seem to be a conflict, please backport manually. Here are approximate instructions:
git checkout 0.4.x
git pull
Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 e30f6aafacd4cfc7a7d4d3758ca80ecd933ea044
You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #1308: Migrating to `jupyter-server` 2, `jupyter_client` 7.x'
git push YOURFORK 0.4.x:auto-backport-of-pr-1308-on-0.4.x
"Backport PR #1308 on branch 0.4.x (Migrating to
jupyter-server
2,jupyter_client
7.x)"
And apply the correct labels and milestones.
Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!
Remember to remove the Still Needs Manual Backport
label once the PR gets merged.
If these instructions are inaccurate, feel free to suggest an improvement.
Since jupyterlab 3.6 can support both jupyter-server 1 and 2 so i think we can do the same for voila.
Thanks! I'll give it a try
This PR is based on https://github.com/voila-dashboards/voila/pull/1283 to make
voila
works withjupyter_server
2References
Partially closes https://github.com/voila-dashboards/voila/issues/1304 Closes https://github.com/voila-dashboards/voila/pull/1283
User-facing changes
Voila
now supports thetoken
authentication by using thePasswordIdentityProvider
ofjupyter_server
, but it is disabled by default.Voila
with auto-generated token:Voila
with personalized token:Users will be redirected to the login page if they are trying to access a token-protected
voila
app.Backwards-incompatible changes
python
3.7 is no longer supported.jupyter_client
< 7.4.4 is no longer supported.