voila-dashboards / voila

Voilà turns Jupyter notebooks into standalone web applications
https://voila.readthedocs.io
Other
5.42k stars 503 forks source link

Remove unused `_get_query_string` function #1316

Closed jtpio closed 1 year ago

jtpio commented 1 year ago

References

This _get_query_string util function appears to not be used anywhere else in the code base.

It is also prefixed with a _ which suggests it was as a private utility function within the module before.

Code changes

Remove unused code.

User-facing changes

None

Backwards-incompatible changes

None

github-actions[bot] commented 1 year ago

Binder :point_left: Launch a Binder on branch jtpio/voila/remove-unused-function

trungleduc commented 1 year ago

update galata references

github-actions[bot] commented 1 year ago

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser. For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table | Test file | voila-tree-classic.ipynb | voila-tree-light.ipynb | voila-tree-dark.ipynb | voila-tree-miami.ipynb | basics.ipynb | bqplot.ipynb | dashboard.ipynb | gridspecLayout.ipynb | interactive.ipynb | ipympl.ipynb | mimerenderers.ipynb | bokeh.ipynb | multiple_widgets.ipynb | query-strings.ipynb | reveal.ipynb | | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | | **Render** | | | | | | | | | | | | | | | | | `chromium` | | | | | | | | | | | | | | | | | actual | 97 <- [104 - 121 - 143] -> 208 | 78 <- [84 - 87 - 90] -> 119 | 72 <- [73 - 78 - 89] -> 108 | 83 <- [85 - 86 - 103] -> 116 | 3146 <- [3192 - 3339 - 3510] -> 5098 | 2636 <- [2676 - 2757 - 2867] -> 3262 | 2880 <- [2915 - 2987 - 3140] -> 3477 | 3077 <- [3120 - 3141 - 3159] -> 3451 | 2231 <- [2251 - 2301 - 2343] -> 2620 | 3800 <- [3848 - 3902 - 4114] -> 4843 | 8128 <- [8181 - 8247 - 8634] -> 8681 | 4219 <- [4268 - 4385 - 4487] -> 4966 | 4441 <- [4479 - 4539 - 4660] -> 4906 | 1967 <- [2010 - 2036 - 2143] -> 2154 | 3412 <- [3489 - 3543 - 3717] -> 4252 | | expected | 3379 <- [3442 - 3517 - 3701] -> 3876 | 2976 <- [3227 - 3321 - 3421] -> 3604 | 3608 <- [3623 - 3709 - 3793] -> 3825 | 4453 <- [4453 - 4523 - 4661] -> 4748 | 2559 <- [2655 - 2656 - 2660] -> 2674 | 3982 <- [4079 - 4213 - 4356] -> 4743 | 12183 <- [18509 - 19553 - 20811] -> 21515 | 15319 <- [15660 - 15796 - 15912] -> 16056 | 1517 <- [1920 - 1997 - 2103] -> 2113 |

:exclamation: Test metadata have changed ```diff --- /dev/fd/63 2023-04-13 08:00:49.047669163 +0000 +++ /dev/fd/62 2023-04-13 08:00:49.047669163 +0000 @@ -4,51 +4,49 @@ "BENCHMARK_REFERENCE": "actual" }, "browsers": { - "chromium": "112.0.5615.29" + "chromium": "94.0.4595.0" }, "systemInformation": { "cpu": { - "brand": "Xeon® Platinum 8171M", + "brand": "Xeon® E5-2673 v3", "cache": { "l1d": 65536, "l1i": 65536, - "l2": 2097152, - "l3": 36700160 + "l2": 524288, + "l3": 31457280 }, "cores": 2, - "efficiencyCores": 0, "family": "6", - "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear", + "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear", "governor": "", - "manufacturer": "Intel", - "model": "85", - "performanceCores": 2, + "manufacturer": "Intel®", + "model": "63", "physicalCores": 2, "processors": 1, "revision": "", "socket": "", - "speed": 2.6, + "speed": 2.4, "speedMax": null, "speedMin": null, - "stepping": "4", - "vendor": "Intel", + "stepping": "2", + "vendor": "GenuineIntel", "virtualization": false, "voltage": "" }, "mem": { - "total": 7281270784 + "total": 7291699200 }, "osInfo": { "arch": "x64", "build": "", - "codename": "Jammy Jellyfish", + "codename": "Focal Fossa", "codepage": "UTF-8", "distro": "Ubuntu", - "kernel": "5.15.0-1035-azure", + "kernel": "5.8.0-1040-azure", "logofile": "ubuntu", "platform": "linux", - "release": "22.04.2 LTS", - "serial": "6aae73e2e0d54915b5db66d0d98249f1", + "release": "20.04.3 LTS", + "serial": "cfc067bfcb844f35865e279a1b0e66c5", "servicepack": "", "uefi": false } ```