search

voila-dashboards / voila

Voilà turns Jupyter notebooks into standalone web applications
https://voila.readthedocs.io
Other
5.31k stars 497 forks source link

allow nbclient 0.10 #1462

Closed minrk closed 2 months ago

minrk commented 2 months ago

References

closes #1429

Code changes

increases nbclient upper bound from 0.8 to 0.11.

User-facing changes

current nbclient (0.10) is accepted

Backwards-incompatible changes

None

github-actions[bot] commented 2 months ago

Binder :point_left: Launch a Binder on branch minrk/voila/bump-nbclient

minrk commented 2 months ago

Since tests pass, which means this upper bound was unnecessarily restrictive, I'd recommend removing the upper bound entirely, but I'll leave that to maintainers. I don't believe upper bounds in packages is a practice to recommend in general, except for deeply coupled co-developed packages where unstable APIs are used.

trungleduc commented 2 months ago

I agree with @minrk, bounding the version from 0.4 to 0.11 seems redundant. What do you think @martinRenou @jtpio

jtpio commented 2 months ago

Sounds good. And CI can help catch potential issues with future versions.

trungleduc commented 2 months ago

Thanks @minrk