voila-dashboards / voila

Voilà turns Jupyter notebooks into standalone web applications
https://voila.readthedocs.io
Other
5.45k stars 505 forks source link

Unused rendermime registry #477

Open saulshanabrook opened 4 years ago

saulshanabrook commented 4 years ago

It looks like voila creates a rendermime registry and registers jupyter widgets but then never actually uses it to render anything:

From @SylvainCorlay

hum that is right, we use the widget view script tag at the moment. We used not to in the beginning.

vidartf commented 4 years ago

So do you want to remove the dead code, or to have voila use it? 😉

SylvainCorlay commented 4 years ago

A bit of both on my side. When we move to a jlpm-based template we will certainly use thr rendermime system.