voila-dashboards / voila

Voilà turns Jupyter notebooks into standalone web applications
https://voila.readthedocs.io
Other
5.41k stars 502 forks source link

Microsoft Internet Explorer 11 browser support #551

Open llcoolju opened 4 years ago

llcoolju commented 4 years ago

Yes, I know 😅 but I ask anyway ! Some people I work with are stuck with this version and can not upgrade nor install any other browser ... So, dear Voilà team, is there any plan to support this browser ?

maartenbreddels commented 4 years ago

I think it is on the same roadmap as python1 support :) But with a simple template I don't see why I cannot work. What doesn't work actually?

(from mobile phone)

On Thu, 5 Mar 2020, 19:14 llcoolju, notifications@github.com wrote:

Yes, I know 😅 but I ask anyway ! Some people I work with are stuck with this version and can not upgrade nor install any other browser ... So, dear Voilà team, is there any plan to support this browser ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/voila-dashboards/voila/issues/551?email_source=notifications&email_token=AANPEPJNVNCWS3MZ3JOSZD3RF7TXFA5CNFSM4LCPVD62YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IS3ZSOA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANPEPJPUSVIZ5OE45M4BODRF7TXFANCNFSM4LCPVD6Q .

martinRenou commented 4 years ago

I think it is on the same roadmap as python1 support :)

:smile:

But with a simple template I don't see why I cannot work. What doesn't work actually?

I had a report of jupyter-matplotlib not working in Explorer 11. So maybe widgets do not work?

llcoolju commented 4 years ago

Thanks for your replies ! There is some few Javascript errors that seems to prevent voila to execute properly. For example on this template the use of backticks for template literal are not supported and leads IE11 to throw "SCRIPT1014: invalid character" error in console. I also have a "SCRIPT1006: Expected ')'" in console pointing on main.js script on this line Hope this helps !

martinRenou commented 4 years ago

Do you think you could come up with PRs fixing internet explorer support? That would be awesome!

llcoolju commented 4 years ago

Unfortunately this is out of my area of expertise, but I would be glad to contribute by making some tests.