Table not displaying cells with a value of 0

voilab / voilab-pdf-table

PdfKit wrapper that helps to draw informations in simple tables

MIT License

52 stars 26 forks source link

Table not displaying cells with a value of 0 #25

Closed njeri-ngigi closed 5 years ago

njeri-ngigi commented 5 years ago

Steps to reproduce:

pass data with values of 0 to table.addBody()

table.addBody([
        {description: 'Product 1', quantity: 0, price: 20.10, total: 20.10},
        {description: 'Product 2', quantity: 0, price: 4.00, total: 16.00},
        {description: 'Product 3', quantity: 0, price: 17.85, total: 35.70}
    ]);

The cells for quantity are empty

with quantity set to 10, 20, 30, here's the PDF:

Is this a bug? Does it have a work-around?

Drieger commented 5 years ago

I think the problem is in this line of code

https://github.com/voilab/voilab-pdf-table/blob/fa1f0f30031efa72c534b88a58dd36f14f114945/voilab-table.js#L91

While it is not fixed! You might try to pass values as strings, or provide a renderer to handle this case.

tafel commented 5 years ago

Please try with new version 0.5.0