voinage / voinage-xbmc-plugins

Automatically exported from code.google.com/p/voinage-xbmc-plugins
0 stars 0 forks source link

Fix for "Last Resort.py" (XBMC only) #18

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Introduction:

This is a fix for "Last Resort.py" bundled with "Plugin & Python scripting
tutorial". If it is inappropriate to post a fix to this "Issues" section,
please let me know the right way. I've learnt a lot from the tutorial and
felt like contributing. Even after this fix, only Dexter, Peep Show and
Office shows are viewable. The other three (Heroes, House MD & Six Feet
Under) do not work yet.

What steps will reproduce the problem?

- 1. The TV shows listed by "Last Resort.py" do not play in XBMC.

What is the expected output? What do you see instead?

- We expect to see the episodes of TV shows like Dexter, Heroes (listed in
http://www.tvdash.com/tvshows.html). Instead nothing happens when the
episode title is clicked on, in XBMC.

What version of the product are you using? On what operating system?

- XBMC 8.10, on Windows-Vista.

Please provide any additional information below.

- The following changes to line 38 of EPISODES() will help, as addDir
should be called independent of the thumbnail image url. And the url to
addDir does not need the tvdash.com prefix.

---- old (lines 36-38) -----
                if not thumb.find('http://')>0:
                        thumb='http://www.tvdash.com/'+thumb
                        addDir(name,'http://www.tvdash.com/'+url,4,thumb)
---- new (lines 36-38) -----
                if not thumb.find('http://')>0:
                        thumb='http://www.tvdash.com/'+thumb
                addDir(name,url,4,thumb)
-----------------------------

Note:
The modified "Last Resort.py" is attached. It has been edited in Windows
with vim. It might need a dos2unix conversion, for use with Linux XBMC. 

Thanks.

Original issue reported on code.google.com by vijayasa...@gmail.com on 27 Dec 2008 at 8:47

Attachments:

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
It doesn`t need a fix.

They are for you to correct any way you see fit.
It is a learning experience for people , not a way for you to post YOUR method.

I could have fixed it myself - if I had chosen to do so.

Everyone will approach this differently.

I am glad you found the tutorial useful, but you have clogged up my google code 
site
with something that SHOULD NOT BE AN ISSUE.

Original comment by Voinage on 27 Dec 2008 at 5:32

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Do you honestly think i would have used the code i did if this was not a 
tutorial plugin.

Check the VPR - then remove this.

The forum is for things like this not MY ISSUE PAGE.

Which you have now ruined with a non issue.

I cannot delete this now. It will remain here clogging up my issues list.

Original comment by Voinage on 27 Dec 2008 at 5:42

GoogleCodeExporter commented 9 years ago

Original comment by Voinage on 27 Dec 2008 at 5:48

GoogleCodeExporter commented 9 years ago
:) funny guy 

Original comment by vollmer....@gmail.com on 5 Aug 2014 at 10:33