voipmonitor
commented
9 years ago Hi I have not applied the patch fully but I have removed the mempcpy since it is really not needed and not intended to use ever.
2015-02-02 10:34 GMT+01:00 Claus Andersen notifications@github.com:
FreeBSD does not implement mempcpy.
A common workaround is to add mempcpy via the auxilary gcc library ansidecl.h. This is however only available when using gcc.
On FreeBSD we prefer to compile using clang. The interesting thing is that mempcpy is not even used in the code as it has been commented out for a long time. We then require ansidecl.h on FreeBSD even though it is never used.
Because of this I have removed the unused code to get a clean compile with
clang. Other workarounds would be possible but seems to be a waste of time.
You can view, comment on, or merge this pull request online at:
https://github.com/voipmonitor/sniffer/pull/11 Commit Summary
- Merge pull request #1 from voipmonitor/develop
- Removed unused references to mempcpy and hence dependency on ansidecl.h. This enables clean compile with clang rather than gcc.
File Changes
- M tar.cpp https://github.com/voipmonitor/sniffer/pull/11/files#diff-0 (27)
Patch Links:
- https://github.com/voipmonitor/sniffer/pull/11.patch
- https://github.com/voipmonitor/sniffer/pull/11.diff
— Reply to this email directly or view it on GitHub https://github.com/voipmonitor/sniffer/pull/11.
Best regards Martin Vit
FreeBSD does not implement mempcpy.
A common workaround is to add mempcpy via the auxilary gcc library ansidecl.h. This is however only available when using gcc.
On FreeBSD we prefer to compile using clang. The interesting thing is that mempcpy is not even used in the code as it has been commented out for a long time. We then require ansidecl.h on FreeBSD even though it is never used.
Because of this I have removed the unused code to get a clean compile with clang. Other workarounds would be possible but seems to be a waste of time.