Closed ClausAndersen closed 9 years ago
Hi,
thank you I have applied the patch with slight change in error text when json not found - there is no need to print error now only if non of the library has been found. Improving mysql libraries would be nice.
2015-02-02 14:27 GMT+01:00 Claus Andersen notifications@github.com:
Hi,
- Added FreeBSD specific paths in LDFLAGS for mysql.
- Added detection for json/json-c
- Added detection of LIBDL (Linuxism)
- Change used of LDFALGS rather than CXXFLAGS when liniking
With these changes you get a clean compile on FreeBSD with clan using the following procedure:
pkg install -y libexecinfo libpcap unixodbc mysql56-client libvorbis libogg vorbis-tools gmake git autotools snappy libssh rrdtool pkgconf snappy json-c cd /usr/src git clone https://github.com/voipmonitor/sniffer.git autoconf ./configure setenv CXX '/usr/bin/c++' setenv CC '/usr/bin/cc' gmake
If these patches are accepted I will improve detection of mysql libraries. Right now it depends on the path rather than proper detection. I am not to happy with allow multiple definitions as well - but that seems to originate from Asterisk - will investigate if this can be improved. But this is a start.
Kind Regards,
Claus
You can view, comment on, or merge this pull request online at:
https://github.com/voipmonitor/sniffer/pull/12 Commit Summary
- Adapt autotools for FreeBSD
File Changes
- M Makefile.in https://github.com/voipmonitor/sniffer/pull/12/files#diff-0 (16)
- M configure.in https://github.com/voipmonitor/sniffer/pull/12/files#diff-1 (14)
Patch Links:
- https://github.com/voipmonitor/sniffer/pull/12.patch
- https://github.com/voipmonitor/sniffer/pull/12.diff
— Reply to this email directly or view it on GitHub https://github.com/voipmonitor/sniffer/pull/12.
Best regards Martin Vit
Hi,
With these changes you get a clean compile on FreeBSD with clan using the following procedure:
If these patches are accepted I will improve detection of mysql libraries. Right now it depends on the path rather than proper detection. I am not to happy with allow multiple definitions as well - but that seems to originate from Asterisk - will investigate if this can be improved. But this is a start.
Kind Regards, Claus