search

voipmonitor / sniffer

VoIPmonitor sniffer sources
227 stars 105 forks source link

Improved cross platform mysql detection #13

Closed ClausAndersen closed 9 years ago

ClausAndersen commented 9 years ago

Hi,

Now with improved mysql detection.

Rgds, Claus

voipmonitor commented 9 years ago

Would you please do patch againts the latest develop branch? Dne 2. 2. 2015 18:25 "Claus Andersen" notifications@github.com napsal(a):

Hi,

Now with improved mysql detection.

Rgds,

Claus

You can view, comment on, or merge this pull request online at:

https://github.com/voipmonitor/sniffer/pull/13 Commit Summary

  • Adapt autotools for FreeBSD
  • Change autotools to detect mysql_config and share between configure and Makefile
  • Portable detection of mysql libraries

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/voipmonitor/sniffer/pull/13.

ClausAndersen commented 9 years ago

Sure - but it will be later this week. git is still new to me - so I am still strugling with upstream (easy) and merge thereof (where I stumbled)

Rgds, Claus On 2 Feb 2015 18:42, "Martin Vit" notifications@github.com wrote:

Would you please do patch againts the latest develop branch? Dne 2. 2. 2015 18:25 "Claus Andersen" notifications@github.com napsal(a):

Hi,

Now with improved mysql detection.

Rgds,

Claus

You can view, comment on, or merge this pull request online at:

https://github.com/voipmonitor/sniffer/pull/13 Commit Summary

  • Adapt autotools for FreeBSD
  • Change autotools to detect mysql_config and share between configure and Makefile
  • Portable detection of mysql libraries

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/voipmonitor/sniffer/pull/13.

— Reply to this email directly or view it on GitHub https://github.com/voipmonitor/sniffer/pull/13#issuecomment-72501304.

ClausAndersen commented 9 years ago

Hi,

I had a little extra time. I have merged with upstream and pushed the changes to my repo. I can see the "Resolve merge conflicts" commit seems to be part of this pull request automatically. I think I have done what I was asked to do. Let me know if there are more buttons to press.

Rgds, Claus

voipmonitor commented 9 years ago

Hi, I did not managed to do it proper way so I just downloaded the configure.in from your repo and replaced mine and commit it to our develop branch. It works properly on linux as well as our freebsd test machine. Thank you very much for your work.

2015-02-03 10:51 GMT+01:00 Claus Andersen notifications@github.com:

Hi,

I had a little extra time. I have merged with upstream and pushed the changes to my repo. I can see the "Resolve merge conflicts" commit seems to be part of this pull request automatically. I think I have done what I was asked to do. Let me know if there are more buttons to press.

Rgds, Claus

— Reply to this email directly or view it on GitHub https://github.com/voipmonitor/sniffer/pull/13#issuecomment-72622241.

Best regards Martin Vit

ClausAndersen commented 9 years ago

Hi Martin,

Super!

You have been very responsive, so our next step will be to create a FreeBSD package which we will maintain. That will make FreeBSD uptake even better.

Then we will start examining the code closer and get back to you. I see that you have made good performance progress with new threads. We want to investigate threading in the main pcap thread. We have access to the full line of Napatech NICs (Including the new 100G(!) sustained). The driver developer estimated that the sniffer could prpbably not handle more than 20G with the current thread implementation. That work will happen on FreeBSD as well - but we will naturally ensure it is cross platform. We will contact you again to hear your vision when we are ready to proceed.

All the best, Claus On 3 Feb 2015 17:49, "Martin Vit" notifications@github.com wrote:

Hi, I did not managed to do it proper way so I just downloaded the configure.in from your repo and replaced mine and commit it to our develop branch. It works properly on linux as well as our freebsd test machine. Thank you very much for your work.

2015-02-03 10:51 GMT+01:00 Claus Andersen notifications@github.com:

Hi,

I had a little extra time. I have merged with upstream and pushed the changes to my repo. I can see the "Resolve merge conflicts" commit seems to be part of this pull request automatically. I think I have done what I was asked to do. Let me know if there are more buttons to press.

Rgds, Claus

— Reply to this email directly or view it on GitHub https://github.com/voipmonitor/sniffer/pull/13#issuecomment-72622241.

Best regards Martin Vit

— Reply to this email directly or view it on GitHub https://github.com/voipmonitor/sniffer/pull/13#issuecomment-72686846.

voipmonitor commented 9 years ago

Hi,

ok great let me know I'm willing to cooperate with improving the throughput.

Martin

2015-02-03 18:02 GMT+01:00 Claus Andersen notifications@github.com:

Hi Martin,

Super!

You have been very responsive, so our next step will be to create a FreeBSD package which we will maintain. That will make FreeBSD uptake even better.

Then we will start examining the code closer and get back to you. I see that you have made good performance progress with new threads. We want to investigate threading in the main pcap thread. We have access to the full line of Napatech NICs (Including the new 100G(!) sustained). The driver developer estimated that the sniffer could prpbably not handle more than 20G with the current thread implementation. That work will happen on FreeBSD as well - but we will naturally ensure it is cross platform. We will contact you again to hear your vision when we are ready to proceed.

All the best, Claus On 3 Feb 2015 17:49, "Martin Vit" notifications@github.com wrote:

Hi, I did not managed to do it proper way so I just downloaded the configure.in from your repo and replaced mine and commit it to our develop branch. It works properly on linux as well as our freebsd test machine. Thank you very much for your work.

2015-02-03 10:51 GMT+01:00 Claus Andersen notifications@github.com:

Hi,

I had a little extra time. I have merged with upstream and pushed the changes to my repo. I can see the "Resolve merge conflicts" commit seems to be part of this pull request automatically. I think I have done what I was asked to do. Let me know if there are more buttons to press.

Rgds, Claus

— Reply to this email directly or view it on GitHub https://github.com/voipmonitor/sniffer/pull/13#issuecomment-72622241.

Best regards Martin Vit

— Reply to this email directly or view it on GitHub https://github.com/voipmonitor/sniffer/pull/13#issuecomment-72686846.

— Reply to this email directly or view it on GitHub https://github.com/voipmonitor/sniffer/pull/13#issuecomment-72689354.

Best regards Martin Vit