search

voize-gmbh / reakt-native-toolkit

Combine React Native with Kotlin Multiplatform (KMP)
Apache License 2.0
134 stars 5 forks source link

Library feature #12

Closed charlee-dev closed 1 year ago

charlee-dev commented 1 year ago

Hi. Just a few questions.

Legion2 commented 1 year ago

We are actively using this library and update it to a new react native version if we have time for it. Next supported React Native version should be 0.71 or higher. This brings huge improvements to the compatibility and publishing of this library, see https://github.com/reactwg/react-native-new-architecture/discussions/105. But until then the library is only compatible with react native 0.69.4.

If you find bugs, we are open for PRs.

charlee-dev commented 1 year ago

Thanks for the quick response!

I am a Kotlin developer working on an RN project with Koltin Multiplatform Sdk. I'm ofc working on the SDK part. In our setup, we publish KMM SDK as a library for RN Android, and for the iOS part, we pack it as XCFramework, and both of them are moved into the RN project.

In my day-to-day life, I need to change the RN bridging code in Android Kotlin and iOS Swift code. While working on the SDK, the Android RN project is not enabled in settings.gradle, so we have no code completion in the RN Android module, and we need to open Xcode to update the code.

So I decided to change it. I created a separate KMM module, "bridge", where I can put all the bridging code nice and tidy. I moved Android RN stuff, and all worked as expected, no surprise. Moving iOS bridging code, and converting it to Kotlin so it works with ObjC is a different story of trial and error. But then I found your library, and it looks like my problem was your problem before, and you solved it, which is excellent!

Question: If the library supports React Native version 0.69.4, is it backwards compatible too? Or does it need to be the exact version? We are currently on RN 0.67.3.

Also, I found you because I watched your conference video in Berlin. It sounds like you are working on the exciting stuff. I pleased to meet you.

Legion2 commented 1 year ago

Hi, Regarding your question, technically supporting different RN version is possible, but currently because old RN Android versions are not available in maven repo you get an error wenn your local RN version is not the same as the version specified in the library. Maybe we can change the specific version to a wildcard in Gradle.

Next week I have to work on toolkit to improve the EventEmitter support on iOS. Maybe I can check on that too.

Legion2 commented 1 year ago

@charlee-dev we made a new release with updated react native version, you may want to try to use this release in your app with older react native version. You may need to build the toolkit locally to adjust the rn version. There is now also an example project which may help you integrate the toolkit.

charlee-dev commented 1 year ago

Thank you. I'll give it a go soon. I will let you know if I need help, but I'll open a new issue if I do. 🤞