search

vojtajina / grunt-bump

Grunt.js plugin - Increment package version.
MIT License
651 stars 122 forks source link

feat: support hg in addition to git #170

Closed edcottrell closed 8 years ago

edcottrell commented 8 years ago

Add options hg and hgTagTemplate to bump.js and to README.md Add support for bump:hg (functions in the same way as bump:git)

eddiemonge commented 8 years ago

Not all git commands translate to hg and if hg is supported then svn, perforce, and others have to be supported as well. Feel free to fork and add support for hg in there if you would like.

edcottrell commented 8 years ago

I have to say I'm a little surprised by this. Does the tool really need to be either git-only or one-size-fits-all? Git alone only covers about 69% of users; git + mercurial is over 77%. (See http://stackoverflow.com/research/developer-survey-2015#tech-sourcecontrol) It's unrealistic to expect one developer to submit a single PR that covers all of the top 5 or so source control systems at once. But I'll be happy to fork the project and continue using and developing it if that's what y'all would prefer.

eddiemonge commented 8 years ago

I can't really trust a survey that says tabs is beating spaces by that much of a margin.

Even if that survey is accurate, the 8% is enough for me spend the time required to make sure hg works in all the instances in this as well. Sadly, because this is lacking good test coverage, I can't even guarantee git works in all cases so supporting another vcs is just asking for trouble.

Thank you taking the time to make the PR though, it is appreciated.