search

vojtajina / grunt-bump

Grunt.js plugin - Increment package version.
MIT License
651 stars 122 forks source link

Version 0.7.2 introduced somewhat breaking changes #180

Closed liorcode closed 8 years ago

liorcode commented 8 years ago

The latest version (0.7.2) broke my build due to some breaking changes (https://github.com/vojtajina/grunt-bump/commit/0965945f298e275df971447c1a9dfb7fb0144814) Seems grunt-bump now requires grunt >=1 as a peer dependency, and since I'm still using grunt 0.4 (which is also required by the other grunt plugins I'm using) running npm install breaks. I think this pretty much makes it a breaking change so maybe it would be best to revert the changes and release it again as 1.0.0 or something. It also makes more sense that a plugin which is versioned as 1.x, matches grunt 1.x.

simonkontschak commented 8 years ago

Hi together, I have the same trouble which is related to the new grunt depencency as @liorch88 mentioned. The general problem is, that some libraries are not compatible to 1.x yet. To be able to upgrade grunt-dependend librarires, grunt recommends library-distributors to depend on grunt using "grunt": ">= 0.4.0" (Grunt Changelog - recommendation).

@vojtajina Would it be possible to change the peerDependency to grunt to be compatible with "grunt": "grunt": ">= 0.4.0"?

acjohnso25 commented 8 years ago

+1. My project depends on grunt-bump ^0.7.0. Over the weekend, my project broke, but nothing changed in my project. This is pretty much the textbook definition of "breaking change" IMHO. :)

agallant commented 8 years ago

Another :+1: on this (specifically the peerDependency >= 0.4.0 approach) - thanks!

johnyb commented 8 years ago

If you rely on grunt 1.0 features, please do at least a bump:minor, not a bump:patch. I thought, grunt-bump was about semver, so please stick to it.

jml6m commented 8 years ago

+1, this is very annoying, ended up just removing grunt-bump for now

cristian-sima commented 8 years ago

+1

eddiemonge commented 8 years ago

Published 0.8.0 with the changes the grunt changes. Published 0.7.3 with the reverted changes so nothing should break

eddiemonge commented 8 years ago

It also makes more sense that a plugin which is versioned as 1.x, matches grunt 1.x.

Actually no. The plugin is independent of grunts version

simonkontschak commented 8 years ago

Thanks a lot for solving that fast.