First two issues implementation - Githubissues

vojtajina / helpdesk-client

Helpdesk application - simple JS client, written in angularjs, working with REST service

www.angularjs.org

59 stars 23 forks source link

First two issues implementation #3

Closed alenkacz closed 13 years ago

vojtajina commented 13 years ago

Some general notes to coding style:

function() { ...} note the space before {
if possible, use single quotes ' instead of double "
always space after coma (function(a, b))

Commit messages:

the title (first line) is short description - what's inside this commit
use imperative present tense like "Add new feature..., Fix whatever..." (no past tense)
do not mention related issue, put "Closes #1" into the commit message body instead (github will auto-close the issue and add reference link to commit)
do not say test included, etc. - that's obvious, test case should be always included

vojtajina commented 13 years ago

Merged as 73c1169eeae483a262fba04e315470fd3337160c, thank you very much !