Move developer API key to config file

vojtamolda / homebridge-ecobee3-sensors

Homebridge plugin that exposes Ecobee 3 sensors as HomeKit accessories.

https://www.npmjs.com/package/homebridge-ecobee3-sensors

MIT License

26 stars 15 forks source link

Move developer API key to config file #14

Closed tekuonline closed 7 years ago

tekuonline commented 7 years ago

This allows users to use their own developer api key if they want to.

vojtamolda commented 7 years ago

It's great to come back from vacations and find a beautiful pull request that fixes #13! Thanks!

tekuonline commented 7 years ago

Based on your feedback I made some changes. First changed the entry to api_key to make it more consistent. Second, on second thought I think its better if we just leave the config sample without api_key for basic users and add another section in readme.md file for advanced users where they can have the entry for the api_key in config. so basically both configs are valid.

vojtamolda commented 7 years ago

Good job, thanks a lot!