search

vojtamolda / homebridge-ecobee3-sensors

Homebridge plugin that exposes Ecobee 3 sensors as HomeKit accessories.
https://www.npmjs.com/package/homebridge-ecobee3-sensors
MIT License
26 stars 15 forks source link

Add support for `vulcanSmart` type #30

Closed thecheatah closed 3 years ago

thecheatah commented 3 years ago

I have the latest Ecobee and needed to add the vulcanSmart model to get it to work

Added the following to platform.js

  for (var thermostatConfig of reply.thermostatList) {                                                                                                                                                                                                                     
    if ((thermostatConfig.modelNumber != 'vulcanSmart') && (thermostatConfig.modelNumber != 'athenaSmart') && (thermostatConfig.modelNumber != 'apolloSmart') && (thermostatConfig.modelNumber != 'nikeSmart')) {                                                          
      this.log.info("Not supported thermostat | " + thermostatConfig.name + " (" + thermostatConfig.modelNumber + ")");                                                                                                                                                    
      continue
vojtamolda commented 3 years ago

Hello @thecheatah,

Thanks a lot for sharing your patch. The change looks great. Could you, please, submit it as a pull-request here?

Thanks and have a good one!

Vojta

thecheatah commented 3 years ago

@vojtamolda added pull request here: https://github.com/vojtamolda/homebridge-ecobee3-sensors/pull/31

vojtamolda commented 3 years ago

Thanks for the PR! I have just published version 0.1.7 to NPM.