search

vojtapolasek / vojtux

Scripts and documentation about accessible version of Fedora
47 stars 8 forks source link

Package monitor-toggle installation and configuration into RPM #49

Closed kk-at-redhat closed 10 months ago

kk-at-redhat commented 1 year ago

Thank you! Suggested changes with macros have been tested and look good. Additional sections added as requested.

vojtapolasek commented 11 months ago

Hello @kk-at-redhat and thank you. This is almost ready. Please review the suggestions I put there and rebase the PR. We forgot about one thing which already hit us in the past; these two sections need to go to the spec file since we are updating the dconf databse:

dconf update

%postrm
dconf update

Then I think it is ready to be merged.

vojtapolasek commented 10 months ago

Hello @kk-at-redhat just one more thing, the package should be added to vojtux-common kickstart so that it gets installed.

kk-at-redhat commented 10 months ago

Thank you. Added package are requested and fixed a conflict.

vojtapolasek commented 10 months ago

Aha @kk-at-redhat one more rebase please. Thank you.

kk-at-redhat commented 10 months ago

Rebased and resolved conflicts.