search

vokal / Cat2Cat

Creates a category on UIImage from Asset Catalogs in order to reduce typos and enable auto-complete with image names.
MIT License
46 stars 11 forks source link

Generate constant struct of image names #19

Closed vokal-isaac closed 9 years ago

vokal-isaac commented 9 years ago

... and use those constants in the image-getting methods. Having these constants generated provides the end-consumer with a non-stringly-typed way to use + [UIImage imageNamed:inBundle:compatibleWithTraitCollection:] if they so choose, to work around #12.

@vokal/ios-developers Code review?

designatednerd commented 9 years ago

Looks good to me pending travis

seanwolter commented 9 years ago

So great

vokal-isaac commented 9 years ago

Travis likes it.

vokal-isaac commented 9 years ago

Also, once this is merged, it will need to be tagged 1.4.0 and pod trunk pushed.

designatednerd commented 9 years ago

I'll get it done

designatednerd commented 9 years ago

@vokal-isaac Sad trombone - when I ran pod spec lint it looks like BRLOptionParser pulled their 0.3.1 tag: 

[!] /Applications/Xcode.app/Contents/Developer/usr/bin/git clone https://github.com/barrelage/BRLOptionParser.git /private/var/folders/2w/_5g70ypd601056s6t9pn73q80000gq/T/CocoaPods/Lint/Pods/BRLOptionParser --single-branch --depth 1 --branch v0.3.1

Cloning into '/private/var/folders/2w/_5g70ypd601056s6t9pn73q80000gq/T/CocoaPods/Lint/Pods/BRLOptionParser'...

warning: Could not find remote branch v0.3.1 to clone.

fatal: Remote branch v0.3.1 not found in upstream origin

Unexpected end of command stream

https://github.com/stephencelis/BRLOptionParser/releases

vokal-isaac commented 9 years ago

Hmmm... where's it getting that from? I don't see it in the podspec (the Podfile has pod 'BRLOptionParser', :git => 'https://github.com/vokal-isaac/BRLOptionParser.git' #'~> 0.3.1'—I think 0.3.1 was what I was anticipating would contain the fix that I made in my fork or something similar and while a different fix from mine was implemented, the podspec/tag for BRLOptionParser hasn't been updated).

vokal-isaac commented 9 years ago

Actually, it may not matter—it may just be one of those times when using the --allow-warnings flag is the thing to do.

designatednerd commented 9 years ago

if you ~> 0.3.1, I believe that means it's supposed to be at least 0.3.1. If there's no tag, I'd advise just pointing it at a specific commit for now.

vokal-isaac commented 9 years ago

Yes, but I don't actually reference 0.3.1 anywhere—there's a commented-out bit about it, but it's actually pointing at my fork, via :git =>, which precludes using a version.

designatednerd commented 9 years ago

Oh yeah, wait a second - why does this even give a shit about BRLOptionParser, it's not a part of the podspec. Lemme update cocoapods, I know they sent out a patch relelase.

designatednerd commented 9 years ago

awesome. No update, but pod spec lint fails and pod trunk push works.

¯\_(ツ)_/¯

vokal-isaac commented 9 years ago

I think pod spec lint is overly-sensitive. pod trunk push also does some linting and it's also overly-sensitive, which is why we've got that note about potentially needing the --allow-warnings flag in our private podspec repo.