Mustache! Swift! - Githubissues

vokal / Cat2Cat

Creates a category on UIImage from Asset Catalogs in order to reduce typos and enable auto-complete with image names.

MIT License

46 stars 11 forks source link

Mustache! Swift! #9

Closed vokal-isaac closed 9 years ago

vokal-isaac commented 9 years ago

Sorry about all the Pods overhead.

@designatednerd Who else should I @-ping to potentially review?

designatednerd commented 9 years ago

@seanwolter @bryanluby @chillpop @jacobvo ... I'll think of more once autocomplete is working again :P

designatednerd commented 9 years ago

Couple questions:

Have you updated the binary in the cocoapod and wherever else it needs to be updated? I think I only saw the binary updated in one place here.
Have you bumped the podspec?

vokal-isaac commented 9 years ago

Probably not.
Definitely not.

designatednerd commented 9 years ago

Well....could ya?

vokal-isaac commented 9 years ago

Should it be the same (release-built?) binary in:

CocoaPod/Cat2Cat
SampleiOSApp/Cat2CatExample/Cat2CatExample/Utilities/Cat2Cat
SampleMacApp/Cat2CatExampleMac/Cat2CatExampleMac/Utilities/Cat2Cat
SampleSwiftiOSApp/Cat2CatExampleSwift/Cat2CatExampleSwift/Utilities/Cat2Cat

If so, can I put it in one place (presumable CocoaPod/Cat2Cat) and symlink it in the others?

Also, are the image catalogs identical across the sample projects, or are they different on Mac/iOS? (That is, can they exist in one place and be symlinked in the other place(s)?)

vokal-isaac commented 9 years ago

I've fixed the SHOUTY constants, bumped the podspec version, edited the documentation, updated the binary in the CocoaPod directory, and replaced the example binaries with symlinks to that one.

designatednerd commented 9 years ago

Yeah, the asset catalogs are the same as well, so if the symlinks actually work, then you should do that with the asset catalogs as well. Make sure everything still builds/passes though.

vokal-isaac commented 9 years ago

The symlinks seem to work fine for the Cat2Cat binary, but I can't seem to get symlinks or aliases to work completely for the asset catalogs.

designatednerd commented 9 years ago

Good to pull.