search

vokal / MapCraft-Android

Minecraft Map Viewer for Android
2 stars 0 forks source link

Add a DynMap based server instead of Overviewer #3

Open wmbest2 opened 11 years ago

wmbest2 commented 11 years ago
nick-fedesna commented 11 years ago

We're going to need to rethink how we're persisting in the database to support different servers. Each type of server is probably going to need it's own tables for it's respective data values. The derived classes can then call up their respective tables. It might just be easier to have separate databases for each type though otherwise the single DBHelper is going to need to switch on the type and it could get bloated and messy.

We should probably refactor Server into a base class and derive OverviewerServer for polymorphism. There are going to be some things that need to be moved from TileSet into OverviewerTileSet as well to support polymorphism. I'm working on creating Marker models now, but they will also need to be refactored to have a base class once I see how DynMap provides it's marker data.

wmbest2 commented 11 years ago

Nick we shouldn't need separate tables for each server type... The Models should be relatively generic enough. Just focus on the markers Im getting all the server stuff wrapped up tonight. The only thing I think might be necessary is a type field on the Server model to disguise between the 2 servers we plan to support. Im not targeting others as its not necessary.

William Best Android Engineer VOKAL INTERACTIVE

m: +1.717.917.1262 w: +1.312.527.4719 e: bill.best@vokalinteractive.com (mailto:billl.best@vokalinteractive.com) in: wmbest2 w: www.vokalinteractive.com (http://www.vokalinteractive.com/)

On Saturday, January 19, 2013 at 8:51 PM, Nick Fedesna wrote:

We're going to need to rethink how we're persisting in the database to support different servers. Each type of server is probably going to need it's own tables for it's respective data values. The derived classes can then call up their respective tables. It might just be easier to have separate databases for each type though otherwise the single DBHelper is going to need to switch on the type and it could get bloated and messy. We should probably refactor Server into a base class and derive OverviewerServer for polymorphism. There are going to be some things that need to be moved from TileSet into OverviewerTileSet as well to support polymorphism. I'm working on creating Marker models now, but they will also need to be refactored to have a base class once I see how DynMap provides it's marker data.

— Reply to this email directly or view it on GitHub (https://github.com/vokalinteractive/MapCraft-Android/issues/3#issuecomment-12465143).

nick-fedesna commented 11 years ago

Ya I just realized that too since all we really need to focus on is getting the data and mapping it into data the we can use. The only thing that worries me is that TJ said DynMap doesn't use the same angles for north direction. I'm sure we'll figure it out. You may want to hold off for a bit now, since I've been working on adding getting markers to server and a marker db table & model class.