Remove NSString category and replace with object.

vokal / VOKMultiImagePicker-iOS

A multiple image picker using PhotoKit.

MIT License

12 stars 7 forks source link

Remove NSString category and replace with object. #16

Closed lquigley closed 9 years ago

lquigley commented 9 years ago

@vokalinteractive/ios-developers I replaced a category with an object to help avoid conflicts when the pod is used in other projects.

brockboland commented 9 years ago

LGTM

lquigley commented 9 years ago

@chillpop @brockboland I removed the unnecessary vok prefix on the methods. I also accidentally uploaded another commit for removing albums without assets. It might need a re-review. Sorry.

brockboland commented 9 years ago

Couple 'a tweaks to the empty album logic and good to go!

lquigley commented 9 years ago

@brockboland Should be good to go now.

brockboland commented 9 years ago

LGTM

chillpop commented 9 years ago

At some point are you guys going to bump the version number in the pod spec and pod trunk push this?

lquigley commented 9 years ago

Yes. I would need a senior dev to tag that version once we are ready. I think we have one more issue to fix.

chillpop commented 9 years ago

ok, I can do it if you get to it today.