search

vokal / Vokoder

A lightweight core data stack with efficient importing and exporting on the side.
MIT License
16 stars 14 forks source link

Swift 3-ier naming #118

Closed designatednerd closed 7 years ago

designatednerd commented 7 years ago

This PR adds a swift 3-style shared static singleton wrapper and updates the names of a couple other methods to make them a bit more in line with Swift 3 naming practices.

designatednerd commented 7 years ago

@brockboland @bryanluby @vokal-isaac @chillpop and whoever else wants to chime in: Review please?

designatednerd commented 7 years ago

Not sure WTF is going on with Travis - running from the command line on my machine with a similar command, the stuff that's failing is passing. Any of you guys seen these failures before?

brockboland commented 7 years ago

I remember some of these changes being part of the intended change set for the 4.0.0 release, but I guess I missed that final step of renaming these methods after the automated migration.

I share @vokal-isaac's concern about versioning here, since this does change the Swift API for some methods. Could we leave the old method signature in place, as a pass-through call to the new method with a deprecation message?

vokal-isaac commented 7 years ago

^^ Yes, please.

designatednerd commented 7 years ago

Yeah will do, lemme see if I can get Travis playing nice

designatednerd commented 7 years ago

Deprecation warnings added - last run only tvOS build failed and it ran fine locally, so let's see if it pukes again

designatednerd commented 7 years ago

OK, I've now reverted every suggested change by Xcode 8.2 and it's still not passing on everything. The last several sets of tests have had completely different sub-test failures, and there's nothing consistent I see about what's failing other than it's puking somewhere around where it's trying to start the simulator.

Any thoughts/suggestions?

brockboland commented 7 years ago

It ran fine locally. I restarted the failed job, since Travis occasionally fails with that Exit code 65 error. I've found a bunch of theories and potential solutions online, but we haven't figured out yet what's causing that. I keep hoping that a fastlane or scan update will solve it.

designatednerd commented 7 years ago

@brockboland it's a Festivus miracle, they all passed!

brockboland commented 7 years ago

MERGE BEFORE IT CHANGES ITS MIND

brockboland commented 7 years ago

4.1.0 now available https://cocoapods.org/pods/Vokoder