Allow setting an explicit database URL (in master)

vokal / Vokoder

A lightweight core data stack with efficient importing and exporting on the side.

MIT License

16 stars 14 forks source link

Allow setting an explicit database URL (in master) #93

Closed brockboland closed 8 years ago

brockboland commented 8 years ago

These changes are all @chillpop commits from #92. I cherry-picked them into a new branch for merge into master.

As long as Travis doesn't have any issues with it, I'm going to merge this, since the code has already been reviewed and tweaked in that previous PR.

@vokal/ios-developers FYI

brockboland commented 8 years ago

so that's how it's gonna be.

It's passing locally, I'll look into it.

brockboland commented 8 years ago

Looks like Travis was just having a day: I re-ran the three jobs individually yesterday and they all passed. Just restarted the build to confirm they all still pass OK, and if so, I'll merge this.

brockboland commented 8 years ago

Travis is definitely having some issues with Xcode 8: these just fail to build for no reason sometimes. I'll keep an eye on it in future PRs and see if there's anything that might need to change.