search

vokal / vip

Vokal Image Proxy is a lightweight image proxy designed for easy resizing and caching of images for mobile applications.
MIT License
2 stars 7 forks source link

Support CMYK JPEG files #107

Open foresmac opened 9 years ago

foresmac commented 9 years ago

Go 1.5 now supports them; may just require a recompile on 1.5. Add test case with CMYK JPEG file.

scottferg commented 9 years ago

Yup. I'd be curious what a test would look like.

foresmac commented 9 years ago

Steve from Trunq posted some test JPEGs which he couldn't upload because they were saved as CMYK by a graphic designer.

jrit commented 9 years ago

Part of the problem is that we shouldn't be serving CMYK jpegs either, so if they are accepted for upload, they should always be converted to RGB before they are stored on S3 even for serving the full original size.

foresmac commented 9 years ago

Yeah, that's pretty trivial to do and what I had always envisioned.