search

vokal / vip

Vokal Image Proxy is a lightweight image proxy designed for easy resizing and caching of images for mobile applications.
MIT License
2 stars 8 forks source link

Let's try and get cvr working #111

Closed foresmac closed 9 years ago

foresmac commented 9 years ago

@vokal/systems @jrit

jrit commented 9 years ago

Needs &removepath=vip/

jrit commented 9 years ago

Was this with multiple modes?

foresmac commented 9 years ago

yeah

foresmac commented 9 years ago

It should basically be exactly what I sent over in the coverage.txt file via email.

jrit commented 9 years ago

OK, good, looks like it is parsing it correctly. I don't understand why sometimes Go considers the closing brace part of the covered code and sometimes does not. But, it looks like it considers the closing brace to be covered if the block is entered, so maybe it skews the percent a little, but it doesn't appear to be "wrong" in the sense that it says something isn't covered when it is. The percent likely won't agree with what Go Cover says the percent is as a result though.

jrit commented 9 years ago

LGTM, though obviously you want to reduce the passing threshold if you'd like to see the build pass