search

vokal / vip

Vokal Image Proxy is a lightweight image proxy designed for easy resizing and caching of images for mobile applications.
MIT License
2 stars 7 forks source link

See about using `vips` for image rotation. #80

Open foresmac opened 9 years ago

foresmac commented 9 years ago

Even if we don't enable libexif, changing the existing rotation code should also see performance improvements.

Need to write benchmarks for GetRotatedImage() to analyze before/after numbers.

scottferg commented 9 years ago

This will require modifying the library we're using. On Jan 28, 2015 5:16 PM, "Chris Foresman" notifications@github.com wrote:

Even if we don't enable libexif, changing the existing rotation code should also see performance improvements.

Need to write benchmarks for GetRotatedImage() to analyze before/after numbers.

— Reply to this email directly or view it on GitHub https://github.com/vokal/vip/issues/80.

foresmac commented 9 years ago

libvips doesn't support image rotation?

scottferg commented 9 years ago

The libvips bindings I'm using doesn't expose it. We'll want to fork and update it.

On Thu, Jan 29, 2015 at 1:39 PM, Chris Foresman notifications@github.com wrote:

libvips doesn't support image rotation?

— Reply to this email directly or view it on GitHub https://github.com/vokal/vip/issues/80#issuecomment-72089821.

Scott Ferguson Director of Systems and Web Engineering VOKAL INTERACTIVE

m: +1.312.324.0829 e: scott.ferguson@vokalinteractive.com scott.ferguson@vokalinteractive.com sn: http://gplus.to/scottferguson

foresmac commented 9 years ago

OIC, weird. Ok.

foresmac commented 9 years ago

The dev of the vips go library is adding support for rotation: https://github.com/DAddYE/vips/issues/11

scottferg commented 9 years ago

You just had to mention the django ticket On Mar 25, 2015 4:31 PM, "Chris Foresman" notifications@github.com wrote:

The dev of the vips go library is adding support for rotation: DAddYE/vips#11 https://github.com/DAddYE/vips/issues/11

— Reply to this email directly or view it on GitHub https://github.com/vokal/vip/issues/80#issuecomment-86224891.

foresmac commented 9 years ago

I'm going to make a PDF of it and append it to my resume, which is now part of my .sig file.

foresmac commented 9 years ago

Here is an alternative Go package for libvips we could look at: https://github.com/h2non/bimg

scottferg commented 9 years ago

Looks like much better support

--------

Scott Ferguson

Director of Systems & Web Engineering

scott.ferguson@vokal.io

c: 312.324.0829

o: 312.527.4719

vokal.io http://www.vokal.io/

On Tue, Apr 7, 2015 at 1:11 PM, Chris Foresman notifications@github.com wrote:

Here is an alternative Go package for libvips we could look at: https://github.com/h2non/bimg

— Reply to this email directly or view it on GitHub https://github.com/vokal/vip/issues/80#issuecomment-90684310.

foresmac commented 9 years ago

Yeah, vips is very specifically written, whereas this seems a little more flexible. It's only at version 0.12, though, so I'm loathe to add it until Trunq ships and I can dig into the course and see if we have to fork to improve the codebase before leveraging it.