search

vokal / vip

Vokal Image Proxy is a lightweight image proxy designed for easy resizing and caching of images for mobile applications.
MIT License
2 stars 7 forks source link

Simplify square cropping #91

Closed foresmac closed 9 years ago

foresmac commented 9 years ago

No need to perform an extra step when generating square thumbnails. If both width and height are specified in vips.Options, and it’s the same value, it just does the right thing.

See code here: https://github.com/DAddYE/vips/blob/master/vips.go#L124-L148

Added square thumb resize test and benchmark. I tested the difference between the new and old version; this is only about a 5% savings in speed, which isn’t much, but it does simplify the code quite a bit.

camsom commented 9 years ago

LGTM

foresmac commented 9 years ago

@scottferg Any concerns with this?

scottferg commented 9 years ago

Nope LGTM

scottferg commented 9 years ago

Scoot on

scottferg commented 9 years ago

Scoot the planet