search

vokkim / signalk-ruuvitag-plugin

Signal K plugin to provide RuuviTag data
MIT License
4 stars 8 forks source link

Feature request: make tag Location configurable for more locations #12

Closed ghost closed 3 years ago

ghost commented 3 years ago

Feature request: make tag Location configurable for more locations

Reason: Although it's easy to simply edit index.js and add more into enum, it would be much more user friendly if this can become configurable from within the plugin in the GUI.

vokkim commented 3 years ago

Made some changes and published 1.2.1. However I do not have any RuuviTags with me at this time, so if you could test the new version and report back if any errors found, thanks!

vokkim commented 3 years ago

Ah, saw your comment on the PR, thanks!

ghost commented 3 years ago

Sorry, had to re-open, @vokkim

With 1.2.1 I get the following in the server log:

Feb 25 20:15:54 processLeAdvertisingReport: Caught illegal packet (buffer overflow): ReferenceError: pathEnvironment is not defined

I'm able to stop this when I disable the plugin. And I can't see any paths from the plugin in the data browser. Not sure this has to do with your changes, but did not encounter this when I only tested the PR.

edit: and some bits with debug logging:

Feb 25 20:21:31 POST /skServer/plugins/ruuvitag/config 200 18.210 ms - 39 Feb 25 20:21:31 GET /skServer/plugins 200 7.547 ms - - Feb 25 20:23:10 Could not parse JSON options:Unexpected end of JSON input Feb 25 20:23:10 POST /skServer/plugins/ruuvitag/config 200 21.087 ms - 39 Feb 25 20:23:10 GET /skServer/plugins 200 15.114 ms - - Feb 25 20:23:13 GET /skServer/plugins 200 14.294 ms - - Feb 25 20:23:15 Could not parse JSON options:Unexpected end of JSON input Feb 25 20:23:15 POST /skServer/plugins/ruuvitag/config 200 24.503 ms - 39 Feb 25 20:23:15 GET /skServer/plugins 200 13.731 ms - - Feb 25 20:23:18 GET /skServer/plugins 200 14.198 ms - - Feb 25 20:23:20 Could not parse JSON options:Unexpected end of JSON input Feb 25 20:23:20 POST /skServer/plugins/ruuvitag/config 200 32.211 ms - 39 Feb 25 20:23:20 GET /skServer/plugins 200 15.580 ms - - Feb 25 20:23:21 processLeAdvertisingReport: Caught illegal packet (buffer overflow): ReferenceError: pathEnvironment is not defined

vokkim commented 3 years ago

Woops, my bad! Tried to quick-fix it with 1.2.2, hope it works. Would need some tests for this stuff....

ghost commented 3 years ago

Quick-fix solved it. Thanks very much!