search

vokseverk / Vokseverk.ImageHotspot

A property editor for Umbraco to place a hotspot on an image (e.g. a place on a map).
https://our.umbraco.com/packages/backoffice-extensions/image-hotspot/
12 stars 5 forks source link

Build package for umbraco 9 #16

Open lynnewritescode opened 2 years ago

greystate commented 2 years ago

Hey @lynnewritescode - thanks a bunch for this šŸ‘

I need to take a longer look at this as I've not yet ventured into any nuget stuff for any of our packages.

lynnewritescode commented 2 years ago

Hey @lynnewritescode - thanks a bunch for this šŸ‘

I need to take a longer look at this as I've not yet ventured into any nuget stuff for any of our packages.

Hey! No worries, I found your package recently and might need to use it in an umbraco 9 project, so thought Iā€™d give it a go. Hopefully this helps!

csurfleet commented 2 years ago

Is there anything I can do to move this forward? I really need to use this package in v9 and will happily help out if anything needs doing

greystate commented 2 years ago

@csurfleet I am pretty sure you should be able to take Lynne's code from this PR and use it as is.

Sadly I'm not able to just merge it into the main branch, since I'd loose all of my own build scripts etc. - which is just me wanting to be able to do fixes etc. for all versions.

I do want to be able to provide a nuget package at some point, but I have no timeframe for that yet.

greystate commented 1 year ago

Hey @lynnewritescode & @csurfleet

FYI, there is now an official NuGet package for this:

NuGet: https://nuget.org/packages/Vokseverk.ImageHotspot

Umbraco Marketplace: https://marketplace.umbraco.com/package/vokseverk.imagehotspot

I am not closing this PR yet, because the NuGet package is for Umbraco 10+