voku / HtmlMin

:clamp: HtmlMin: HTML Compressor and Minifier via PHP
MIT License
161 stars 22 forks source link

Upgrade code to work in PHP8 or greater and/or Laravel 9 or greater #85

Closed summercms closed 1 year ago

summercms commented 1 year ago

Fixes https://github.com/voku/HtmlMin/issues/84

This repo doesn't work in PHP 8, 8.1 or 8.2 due to the namespaces not being Capitalized.

Need to update the connecting repos now.

Linked to Pull Requests

https://github.com/voku/html-compress-twig/pull/5

https://github.com/voku/HtmlMin/pull/85

https://github.com/voku/simple_html_dom/pull/95

https://github.com/voku/simple-cache/pull/30

https://github.com/voku/portable-ascii/pull/87

Tested on the following

Tested on PHP 8.2 and Laravel 9.1


This change is Reviewable

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 43 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

summercms commented 1 year ago

Done some digging.

This package fails PSR-1 Chapter 3 rules for Namespaces and Class Names:

Class names MUST be declared in StudlyCaps.

Can share a link to the PSR Spec here: https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-1-basic-coding-standard.md#3-namespace-and-class-names

summercms commented 1 year ago

Closing this as looks like an issue with the auto-discovery loader in the Laravel CMS and not an issue with this package, Laravel or PHP.