voku / HtmlMin

:clamp: HtmlMin: HTML Compressor and Minifier via PHP
MIT License
160 stars 21 forks source link

Fix: trim sizes and srcset attributes values #88

Closed jimblue closed 9 months ago

jimblue commented 11 months ago

This is to improve minification of sizes and srcset attributes.

Fixes #87

Proposed Changes


This change is Reviewable

coveralls commented 11 months ago

Coverage Status

coverage: 95.513% (+3.4%) from 92.09% when pulling 122ae7b845506df4c5d2ea6ef827669a6a87a78e on jimblue:master into ebbbcf91393a057eccf1a1a152c18352696e4c1c on voku:master.

codecov[bot] commented 11 months ago

Codecov Report

Merging #88 (122ae7b) into master (ebbbcf9) will increase coverage by 2.38%. The diff coverage is 100.00%.

:exclamation: Current head 122ae7b differs from pull request most recent head 06bae81. Consider uploading reports for the commit 06bae81 to get more accurate results

@@             Coverage Diff              @@
##             master      #88      +/-   ##
============================================
+ Coverage     92.50%   94.88%   +2.38%     
  Complexity      369      369              
============================================
  Files             2        2              
  Lines           654      861     +207     
============================================
+ Hits            605      817     +212     
+ Misses           49       44       -5     
Files Changed Coverage Δ
src/voku/helper/HtmlMin.php 96.19% <100.00%> (+2.36%) :arrow_up:

... and 1 file with indirect coverage changes

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

jimblue commented 10 months ago

Hey @voku, Any chance to review/merge this PR ? :)