search

voku / portable-ascii

🔡 Portable ASCII library - performance optimized (ascii) string functions for PHP.
MIT License
522 stars 32 forks source link

Is Croatian to ASCII correct? #11

Closed voku closed 5 years ago

voku commented 5 years ago

Example: Is this correct?

"sveučilišt" -> "sveucilist"

Can a native speaker, please check the character-replacement, thanks.

https://github.com/voku/portable-ascii/blob/master/src/voku/helper/data/ascii_by_languages.php#L412

ludifonovac commented 5 years ago

This one is correct although there is another letter in Croatian language which is represented by two letters: dž->dz / Dž->Dz

voku commented 5 years ago

so this is correct? ->

 // Croatian (Hrvatska)
    'hr' => [
        'dž' => 'dz',
        'Dž' => 'Dz',
        'ž' => 'z',
        'Ž' => 'Z',
        'đ' => 'dj',
        'Đ' => 'Dj',
        'č' => 'c',
        'Č' => 'C',
        'ć' => 'c',
        'Ć' => 'C',
        'š' => 's',
        'Š' => 'S',
    ],
ludifonovac commented 5 years ago

yes

voku commented 5 years ago

Thanks for the review. :1st_place_medal: