search

voku / portable-ascii

🔡 Portable ASCII library - performance optimized (ascii) string functions for PHP.
MIT License
522 stars 32 forks source link

Is Finnish to ASCII correct? #12

Closed voku closed 4 years ago

voku commented 5 years ago

Example: Is this correct?

"päiväkoti" -> "paivakoti"

Can a native speaker, please check the character-replacement, thanks.

https://github.com/voku/portable-ascii/blob/master/src/voku/helper/data/ascii_by_languages.php#L424

hur commented 4 years ago

It's not necessarily correct (will change the meaning of the word e.g. lähti vs lahti). The language should still be understandable in most cases ("paivakoti" looks like what you would write if you had no access to a finnish keyboard).

voku commented 4 years ago

Do you know a better way to convert Finnish text in ASCII?

hur commented 4 years ago

I think the current implementation is the best way.

voku commented 4 years ago

@hur Thanks for the re-view. :+1: