search

voku / portable-ascii

🔡 Portable ASCII library - performance optimized (ascii) string functions for PHP.
MIT License
522 stars 32 forks source link

Package size #48

Closed staabm closed 4 years ago

staabm commented 4 years ago

The recent release growed in size by ~45000 lines because of https://github.com/voku/portable-ascii/commit/5417140259b3d2e9a8673908f61e55c4e1346e64

We bundle the lib with our cms and it makes a big portion of our overall application size, see https://github.com/redaxo/redaxo/pull/3662

Do you have any recommendations/suggestions on how we could save in filesize? Maybe we can reduce the size of the data folder when we do some assumptions?

voku commented 4 years ago

Thanks for the hint. I have removed the new comments in these files, so that the file-size should be ~ as big as before.

staabm commented 4 years ago

thank you!

for reference: fixed with https://github.com/voku/portable-ascii/commit/9ca15a8ddd61ad5857d5b71f5a0b991822c615e6

we will give it another try.