volarjs / services

MIT License
134 stars 29 forks source link

Fix regression: `labelDetails` in completions not processed #31

Closed zardoy closed 1 year ago

zardoy commented 1 year ago

labelDetails from ts.CompletionEntry was ignored. Its hard to blame as code was moved.

str:

<script lang="ts">
export default {
    // method snippet such as `activated` completions lacking of label description
}
</script>

Also support for it is declared: https://github.com/volarjs/plugins/blob/583ab20ff61b9c4b1381d72d6e048c66f066edd7/packages/typescript/src/configs/getUserPreferences.ts#L32

johnsoncodehk commented 1 year ago

Made some adjustments, thanks!

tjx666 commented 1 year ago

@zardoy I can see your everywhere 😀

zardoy commented 1 year ago

@tjx666 Well, I'd also happy to see your PRs everywhere 😉