volarjs / services

MIT License
124 stars 25 forks source link

feat(prettier): Allow a Prettier instance to be optional #81

Closed Princesseuh closed 3 months ago

Princesseuh commented 4 months ago

Prior to Volar 2.0, it was possible for upstream consumers to simply not initialize the Prettier plugin if they couldn't find Prettier themselves. This is not possible anymore as the resolving of Prettier has to open inside the plugin's hooks (since you need env to try to find Prettier in the first place, and it's not available in createServicePlugin)

Fix https://github.com/volarjs/services/issues/77

alvgaona commented 3 months ago

@Princesseuh when are we expecting this PR to get merged? Any idea?