volarjs / volar.js

💙🌊
https://volarjs.dev/
MIT License
966 stars 47 forks source link

Integration with CodeMirror #11

Open johnsoncodehk opened 1 year ago

johnsoncodehk commented 1 year ago

We have now completed the Monaco integration and when I checked @vue/repl I noticed it also uses another web code editor called CodeMirror, I was just considering whether it also needs LSP support.

The closest solution at the moment is codemirror-languageserver maintained by @hjr265.

But perhaps a compatibility package between Monaco worker and CodeMirror editor would be a better approach?

For now, I will keep this issue open but I may not do the work because I am not even sure if CodeMirror is still being used or maintained by the community.

johnsoncodehk commented 1 year ago

Closed for the same reason as #12.

johnsoncodehk commented 1 year ago

After re-investigating it I think it is not as difficult as imagined, we don't need to use codemirror-languageserver because we can directly access our own language service.

coder0107git commented 6 months ago

There's also this LSP integration for CodeMirror. It also supports LSP over Websockets but also support's running from a Web Worker. Another thing is that it has a LSP message support matrix (although I'm not sure how up-to-date it is).

Update: It looks like it only supports CodeMirror 5.

johnsoncodehk commented 6 months ago

@coder0107git If you have a project that requires integrating Volar with CodeMirror6 please share it with me and we can assist with the integration while implementing the @volar/codemirror bridge.

NullVoxPopuli commented 6 months ago

:wave: I have an OSS-codemirror6-using project that I'd like to add Volar to :tada: -- https://limber.glimdown.com / https://tutorial.glimdown.com :heart: