volarjs / volar.js

💙🌊

https://volarjs.dev/

MIT License

963 stars 47 forks source link

feat(language-core): improve support for range mapping #206

Closed piotrtomiak closed 2 months ago

piotrtomiak commented 2 months ago

Fixes #203

piotrtomiak commented 2 months ago

Hi! I've added some refinements to the startEnd matching logic. It is more readable now and also it supports the fallback mode out-of-the-box.

johnsoncodehk commented 2 months ago

Since overlapping mapping handling is Angular-specific behavior, I think it's best to keep this implementation in WebStorm-Angular and keep the default implementation simple.

207 Added a method to make mapping logic customizable, can you check if it meets your needs?

piotrtomiak commented 2 months ago

@johnsoncodehk - sounds good! I've copy/paste my implementation of source map to angular plugin and it works fine! Thanks for the changes!