volca / markdown-preview

Markdown Preview Plus -- Enables Chrome to render markdown files as HTML
https://chrome.google.com/webstore/detail/markdown-preview-plus/febilkbfcbhebfnokafefeacimjdckgl
MIT License
237 stars 72 forks source link

Code Syntax Highlighting is now working properly. #46

Closed rafpro closed 8 years ago

rafpro commented 8 years ago

PHP Code block is not being highlighted anymore for me. I am using local stylesheet to enhance code highlighting. I am working on styling for several days. When I installed this extension for the first time, it was wrapping several elements in the code block. But now I am getting only 'keyword' and number for Languages, and 'attribute' and 'value' for CSS.

Is there any way to make highlight.js work from local filesystem?

Will you please give classes to more language tokens?

volca commented 8 years ago

Could you please paste an example? I will test it local.

rafpro commented 8 years ago

Thanks for your quick response. I am going to attach screenshots from our demo markdown file preview.

Java Code Preview Feature Request

image

Plain Preview

image

PHP Issue with code highlighting

image

@volca your markdown extension is awesome, it must be more enhanced if we would get more code highlighting features such as variables, function name, parameters/arguments, block notation (such as end ... do, parentheses, brackets -- if it's possible - I saw this feature with Prisma). Then definitely we will get more control to showcase our code blocks.

Thanks for not keeping navigation panel as it ruins the clean and simple view of the document.

Thumbs up for your great extension :+1:

volca commented 8 years ago

I've uploaded new version plugin to Chrome Store. Let me know if it work.

rafpro commented 8 years ago

Thanks a lot @volca, now we are getting more precise targeting options and ability to use existing highlight.js themes! :+1: