search

volcano-sh / apis

The API (CRD) of Volcano
Apache License 2.0
33 stars 56 forks source link

Add pod annotation key for job RetryCount #127

Closed belo4ya closed 2 months ago

belo4ya commented 3 months ago

Detailed description and discussion here: https://github.com/volcano-sh/volcano/issues/3528

Is your feature request related to a problem? Please describe. Problem is related to log collection and analysis. Without the RetryCount value in the Pod's annotations or environment variables, it is difficult to uniquely identify and filter logs for each individual run of a Job. This makes it challenging to analyze differences between retries.

Describe the solution you'd like I would like to add the Job.Status.RetryCount value to the Pod's annotations (e.g., volcano.sh/job-retry-count=2) and as an environment variable (using Kubernetes downward api). This will facilitate log enrichment, unique run identification, and simplify writing idempotent code.

belo4ya commented 3 months ago

/assign

Monokaix commented 2 months ago

/close

volcano-sh-bot commented 2 months ago

@Monokaix: Closing this issue.

In response to [this](https://github.com/volcano-sh/apis/issues/127#issuecomment-2219295915): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.